nasa / Common-Metadata-Repository

Apache License 2.0
337 stars 92 forks source link

CMR-9797: es-lib-migration #2109

Closed jceaser closed 4 months ago

jceaser commented 4 months ago

Overview

This is the second draft pull request. The first one confused GitHub. Sorry.

What is the feature/fix?

This change is a migration of search code related to elastic query moved into elastic-util under a "search" directory there. Indexer was not moved due to the already expanding size of this request and will be handled in a future request.

What is the Solution?

elastic-utils contains a new package called "search" which contains code related to "searching" elastic. It is not just for the search-app as access-control-app has had some files moved in as well.

You will also find a metric ton of linter changes

What areas of the application does this impact?

Both search-app and access-control-app have been impacted

Checklist

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 42.56198% with 278 lines in your changes are missing coverage. Please review.

Project coverage is 27.96%. Comparing base (7443352) to head (1050e9f). Report is 25 commits behind head on master.

Files Patch % Lines
...c/cmr/elastic_utils/search/es_query_to_elastic.clj 28.72% 129 Missing :warning:
...tils-lib/src/cmr/elastic_utils/search/es_index.clj 11.76% 15 Missing :warning:
...tils-lib/src/cmr/elastic_utils/search/es_debug.clj 20.00% 12 Missing :warning:
...sage-queue-lib/src/cmr/message_queue/queue/sqs.clj 42.85% 12 Missing :warning:
...-control-app/src/cmr/access_control/api/routes.clj 8.33% 11 Missing :warning:
.../src/cmr/elastic_utils/embedded_elastic_server.clj 0.00% 11 Missing :warning:
...-app-lib/src/cmr/common_app/api/request_logger.clj 0.00% 9 Missing :warning:
...rc/cmr/message_queue/test/queue_broker_wrapper.clj 0.00% 7 Missing :warning:
...tils-lib/src/cmr/elastic_utils/datetime_helper.clj 57.14% 6 Missing :warning:
...src/cmr/access_control/services/acl_validation.clj 0.00% 5 Missing :warning:
... and 26 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2109 +/- ## =========================================== - Coverage 58.14% 27.96% -30.19% =========================================== Files 1042 1044 +2 Lines 69804 70355 +551 Branches 1962 1183 -779 =========================================== - Hits 40587 19674 -20913 - Misses 27372 49500 +22128 + Partials 1845 1181 -664 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.