Closed jceaser closed 4 months ago
Attention: Patch coverage is 12.40310%
with 113 lines
in your changes are missing coverage. Please review.
Project coverage is 57.77%. Comparing base (
d3a9ce3
) to head (214b56b
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Approved with one last feedback on a lingering unused comment
Overview
Lint effort
What is the feature/fix?
Clean up the elastic code using clj-kondo
The project file is also cleaned up to use the latest libraries in the lint profile. Then code changes were made to support clj-kondo, bikeshed, and kibit.
What is the Solution?
There are several commits, each for different cleanup tools like Kondo, bikeshed, and kibit so that reviewers can see which changes were made for each of the tools.
Also, all are2 calls have been converted to are3 in spatial lib. Spacial lib should also not issue Warnings about the abs function.
What areas of the application does this impact?
The elastic utils project and the spatial library have been cleaned up. Only elastic utils has been passed through bikeshed and kibit.
Checklist
Test cleanup, there are now no are2 in spatial lib.