nasa / Common-Metadata-Repository

Apache License 2.0

337 stars 92 forks source link

CMR-9845: Allow the tools and services to collection associations to use the generic association API. #2118

Closed eereiter closed 3 months ago

eereiter commented 3 months ago

Overview

What is the feature/fix?

Allow the tools and services to collection associations to use the generic association API.

What is the Solution?

Allow the tools and services to collection associations to use the generic association API.

What areas of the application does this impact?

Tools and Services Associations

Checklist

[ x] I have updated/added unit and integration tests that prove my fix is effective or that my feature works
[ x] New and existing unit and int tests pass locally and remotely with my changes
[ x] I have removed unnecessary/dead code and imports in files I have changed
[ x] I have performed a self-review of my own code
[ x] I have commented my code, particularly in hard-to-understand areas
[ x] I have made corresponding changes to the documentation
[ x] My changes generate no new warnings
[ x] I have cleaned up integration tests by doing one or more of the following:
- de-duped, consolidated, removed dead int tests
- transformed applicable int tests into unit tests
- refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

eudoroolivares2016 commented 3 months ago

Can we update on the https://cmr.earthdata.nasa.gov/search/site/docs/search/api.html#associate-any-concepts there is a note for It's worth noting that associations between collections and services/tools/variables cannot be made through the new association API because these associations require different business rules. to either remove or edit that paragraph with this?

EER - good catch - I have updated the documentation to remove services/tools/. the variable association still can't be made through this API - that is a different ticket.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 21.31148% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 57.74%. Comparing base (b9b874e) to head (5dda168).

Files	Patch %	Lines
...mr/search/services/generic_association_service.clj	12.76%	41 Missing :warning:
...pp/src/cmr/search/services/association_service.clj	36.36%	7 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2118 +/- ## ========================================== - Coverage 57.77% 57.74% -0.03% ========================================== Files 1044 1044 Lines 70356 70391 +35 Branches 1996 1989 -7 ========================================== Hits 40645 40645 - Misses 27851 27892 +41 + Partials 1860 1854 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.