nasa / Common-Metadata-Repository

Apache License 2.0
337 stars 92 forks source link

CMR-9802: Clean up common-lib removing unnecessary util usage #2120

Closed TylerHeald1 closed 3 months ago

TylerHeald1 commented 3 months ago

Overview

Some clean-up of common-lib

What is the feature/fix?

Some namespaces were identified for removal or moving to a more appropriate space, so that was done

What is the Solution?

cmr.common.id-generator removed cmr.common.regex-builder deleted, the only usage of it was swapped for regex literals cmr.common-app.services.ingest.subscription-common moved to common.util

What areas of the application does this impact?

common lib

Checklist

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 57.69%. Comparing base (6d12772) to head (889de75).

Files Patch % Lines
ingest-app/src/cmr/ingest/api/subscriptions.clj 0.00% 1 Missing :warning:
...tions/074_add_normalized_to_subscription_table.clj 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2120 +/- ## ========================================== - Coverage 57.74% 57.69% -0.05% ========================================== Files 1044 1041 -3 Lines 70391 70286 -105 Branches 1994 1985 -9 ========================================== - Hits 40649 40554 -95 + Misses 27891 27882 -9 + Partials 1851 1850 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.