CMR-9777: lint common-lib

[jceaser]

Overview

NOTE: bamboo is still building this

What is the feature/fix?

Ran clj-kondo, bikeshed, and kibit against the common lib

Please summarize the feature or fix.

What is the Solution?

• General cleanups
• Moved a Regex API into the spatial lib which is the only user of this code
• Moved some validation code out of common and into cmr.umm-spec.validation.util which is shared between the client libraries

What areas of the application does this impact?

List impacted areas.

• common-lib
• spatial-lib
• metadata-db
• search-app
• umm-spec

Checklist

• [x] I have updated/added unit and integration tests that prove my fix is effective or that my feature works
• [x] New and existing unit and int tests pass locally and remotely with my changes
• [x] I have removed unnecessary/dead code and imports in files I have changed
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] My changes generate no new warnings
• [ ] I have cleaned up integration tests by doing one or more of the following:
  • de-duped, consolidated, removed dead int tests
  • transformed applicable int tests into unit tests
  • refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each