nasa / Common-Metadata-Repository

Apache License 2.0
337 stars 92 forks source link

CMR-9185: Require clj-kondo in GitHub #2128

Closed jceaser closed 3 months ago

jceaser commented 3 months ago

Overview

Require that code passed clj-kondo before allowing a merge into master

What is the feature/

This change will add clj-kondo as a step to a GitHub action which will be successful if there are no errors from clj-kondo. Warnings will be allowed to pass.

What is the Solution?

The solution is to call clj-kondo in a docker container against the 7 sub-projects that have been cleaned up. The list of sub projects is expected to increase to all. To do this, a new script has been added to dev-system/support/run-kondo.sh to be run by the clj-kondo docker container.

What areas of the application does this impact?

This should impact changes made to access-control-app/src, acl-lib/src, common-app-lib/src, common-lib/src, elastic-utils-lib/src, es-spatial-plugin/src, message-queue-lib/src

Checklist

jceaser commented 3 months ago

if you want to see an example of this code running, you can take a look at my fork:

https://github.com/jceaser/Common-Metadata-Repository/actions/runs/9386228406