Require that code passed clj-kondo before allowing a merge into master
What is the feature/
This change will add clj-kondo as a step to a GitHub action which will be successful if there are no errors from clj-kondo. Warnings will be allowed to pass.
What is the Solution?
The solution is to call clj-kondo in a docker container against the 7 sub-projects that have been cleaned up. The list of sub projects is expected to increase to all. To do this, a new script has been added to dev-system/support/run-kondo.sh to be run by the clj-kondo docker container.
What areas of the application does this impact?
This should impact changes made to access-control-app/src, acl-lib/src, common-app-lib/src, common-lib/src, elastic-utils-lib/src, es-spatial-plugin/src, message-queue-lib/src
Checklist
[-] I have updated/added unit and integration tests that prove my fix is effective or that my feature works
[-] New and existing unit and int tests pass locally and remotely with my changes
[-] I have removed unnecessary/dead code and imports in files I have changed
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[-] I have made corresponding changes to the documentation
[-] My changes generate no new warnings
[-] I have cleaned up integration tests by doing one or more of the following:
de-duped, consolidated, removed dead int tests
transformed applicable int tests into unit tests
refactored to reduce number of system state resets by updating fixtures (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each
Overview
Require that code passed clj-kondo before allowing a merge into master
What is the feature/
This change will add clj-kondo as a step to a GitHub action which will be successful if there are no errors from clj-kondo. Warnings will be allowed to pass.
What is the Solution?
The solution is to call clj-kondo in a docker container against the 7 sub-projects that have been cleaned up. The list of sub projects is expected to increase to all. To do this, a new script has been added to dev-system/support/run-kondo.sh to be run by the clj-kondo docker container.
What areas of the application does this impact?
This should impact changes made to access-control-app/src, acl-lib/src, common-app-lib/src, common-lib/src, elastic-utils-lib/src, es-spatial-plugin/src, message-queue-lib/src
Checklist