nasa / Common-Metadata-Repository

Apache License 2.0
337 stars 92 forks source link

CMR-9970: Disallow negative sizes #2143

Closed sxu123 closed 2 months ago

sxu123 commented 2 months ago

Overview

What is the feature/fix?

Disallow negative numbers in UMM-C file sizes

What is the Solution

Modified the UMM-C schema

What areas of the application does this impact?

CMR ingest

Checklist

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.13%. Comparing base (bbab91c) to head (1ee68ad).

Files Patch % Lines
.../src/cmr/umm_spec/migration/version/collection.clj 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2143 +/- ## ========================================== - Coverage 58.14% 58.13% -0.01% ========================================== Files 1043 1043 Lines 70235 70241 +6 Branches 2010 2010 ========================================== + Hits 40835 40838 +3 - Misses 27529 27532 +3 Partials 1871 1871 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

eudoroolivares2016 commented 2 months ago

We should probably fill out the PR Overview notes