nasa / CryptoLib

Provide a software-only solution using the CCSDS Space Data Link Security Protocol - Extended Procedures (SDLS-EP) to secure communications between a spacecraft running the core Flight System (cFS) and a ground station.
Other
70 stars 28 forks source link

Need to Support Multiple GVCIDS per Single SA #14

Closed IbraheemYSaleh closed 2 years ago

IbraheemYSaleh commented 2 years ago

I removed the SecurityAssocation structuring that allows multiple GVCIDs to use a single SA (after discussing with various people), but it turns out, according to the CCSDS spec, that is supported functionality.

image (10)

We need to re-add that code to the SA structure and update the MySQL code to support multiple GVCIDs for a single SA...

Note that the software must enforce only one active (operational) SA for transferring frames over a particular GVCID -- this means you can have 2 operational SAs servicing 2 different GVCIDs, also possibly 1 operational SA servicing 2 different GVCIDs... The previous structure did not handle the 1st case properly. More thought is required into how this will be done.

IbraheemYSaleh commented 2 years ago

Actually I reread the bluebook... This issue is invalid and what we have now after my aforementioned changes is correct... Per 5.2 C in the BlueBook, "each SA shall be associated to one VC and one VC only". Therefore TC doesn't support multiple GVCIDS per single SA like was originally implemented.

TC-OneSAPerOneVC