search

nasa / CryptoLib

Provide a software-only solution using the CCSDS Space Data Link Security Protocol - Extended Procedures (SDLS-EP) to secure communications between a spacecraft running the core Flight System (cFS) and a ground station.
Other
66 stars 25 forks source link

[nasa/cryptolib#211] Modify sadb_get_sa_from_spi. Unnecessary NULL #238

Closed rjbrown2 closed 1 month ago

rjbrown2 commented 2 months ago

184

The unnecessary reference to a null SA has been removed.

The function has been reworked to work better (more correctly) with the new internal SA setup.

The previous memory leak referenced by this issue has been removed already. We no longer calloc the arsn or iv within the internal sa in this manner.

Consider when reviewing this, if we should modify the character pointers within our SAs to be a set array length. (This would also aid in more easily saving those values in the upcoming save/load capabilities.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.94%. Comparing base (58f82ff) to head (d28cb6e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #238 +/- ## ======================================= Coverage 73.94% 73.94% ======================================= Files 8 8 Lines 2905 2905 Branches 459 459 ======================================= Hits 2148 2148 Misses 583 583 Partials 174 174 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.