nasa / EdsLib

CCSDS SOIS Electronic Data Sheet Tool and Library
Apache License 2.0
31 stars 12 forks source link

Silent failure if no input scripts passed to eds2cfetbl #48

Closed jphickey closed 1 year ago

jphickey commented 1 year ago

Describe the bug When building CFE tables from EDS using this tool, the input data files should be specified as arguments on the command line. If the user passes NO arguments at all, nothing is done - but the tool still returns EXIT_SUCCESS (0).

This tool is typically used from Makefiles/Build scripts - and calling it with no input doesn't make a lot of sense. If that happens it signifies a bug in the build script, where dependencies were not properly passed in. But because the tool still returns a success exit code, the build does not stop. Everything still completes successfully but at the end of the build there are no table files and CFE cannot boot correctly.

To Reproduce Run "eds2cfetbl" with no input arguments, tool returns successfully with a "0" exit code.

Expected behavior Tool should return EXIT_FAILURE instead, which will trigger an error in the parent script/makefile and cause it to stop, so the problem can be addressed.

System observed on: Debian

Reporter Info Joseph Hickey, Vantage Systems, Inc.