nasa / EdsLib

CCSDS SOIS Electronic Data Sheet Tool and Library
Apache License 2.0
31 stars 12 forks source link

BinaryDataEncoding element not handled #68

Closed jphickey closed 8 months ago

jphickey commented 8 months ago

Describe the bug EdsLib encodes all binary data types as 1 bit. The XML schema was since extended to have a "BinaryDataEncoding" which allows larger sizes - in which case all other bits should be padding. But EdsLib is not honoring this element currently.

To Reproduce Use BinaryDataEncoding to make a boolean value stored in an octet (8 bits) for byte alignment. Pack the object, and the binary value will be just 1 bit, with all subsequent elements shifted by 7 bits.

Expected behavior Should be packed as 8 bits, with 7 bits of padding, as the XML intended.

System observed on: Debian

Reporter Info Joseph Hickey, Vantage Systems, Inc.