nasa / EdsLib

CCSDS SOIS Electronic Data Sheet Tool and Library
Apache License 2.0
31 stars 12 forks source link

MsgID check should use SB wrapper #79

Closed jphickey closed 6 months ago

jphickey commented 7 months ago

Describe the bug The MsgId validity check should use the SB IsValidMsgId() check, rather than checking against a fixed maximum. This is the same change as was in nasa/cfe#2489 but EDS has its own msg implementation (originally cloned from the CFE msg module) but this still has the same check and thus needs to be changed here too.

To Reproduce N/A

Expected behavior MsgID validity check should be consistent everywhere

Additional context Single source of truth here should be via CFE_SB_IsValidMsgId()

Reporter Info Joseph Hickey, Vantage Systems, Inc.