nasa / EdsLib

CCSDS SOIS Electronic Data Sheet Tool and Library
Apache License 2.0
31 stars 12 forks source link

Split typedefs from structure definitions #85

Closed jphickey closed 5 months ago

jphickey commented 6 months ago

Is your feature request related to a problem? Please describe. Currently, the struct definitions and the typedefs that go with them are generated into a single header file.

This can cause a backward-compatibility problem, in particular for the "msg" module, which defines an abstract base typedef for its messages here:

https://github.com/nasa/cFE/blob/8cdad66e4eafd11c2ea93d0360867045b77fa981/modules/core_api/fsw/inc/cfe_msg_api_typedefs.h#L107

As the generated EDS file also has a typedef in it, this results in a duplicate/conflicting type definition. (not for the struct, but just the typedef).

Describe the solution you'd like This could be solved if the EDS-generated defs were in separate files, such that the structs could be defined without the typedefs, or vice versa.

Describe alternatives you've considered The underlying issue is that this currently requires a bit of a hack to get the EDS-generated definitions to take the place of the traditional definitions. Goal is to remove the hack, so any solution that gets there is worth considering.

Additional context Ideally the EDS-generated headers should conform to the existing CFE headers, minimizing/avoiding any change on the CFE side where possible to do so.

Requester Info Joseph Hickey, Vantage Systems, Inc.