nasa / FM

The Core Flight System (cFS) File Manager (FM) application.
Apache License 2.0
43 stars 25 forks source link

HK struct members that are duplicated in the Global struct could be consolidated #106

Open thnkslprpt opened 1 year ago

thnkslprpt commented 1 year ago

Checklist

Describe the bug All of the housekeeping struct members except NumOpenFiles are duplicated (identically) in the global struct.

Code snips https://github.com/nasa/FM/blob/e7afedcfdf9ba50eac8a9bdda6ce70a4d1ef709d/fsw/inc/fm_msg.h#L547-L563 https://github.com/nasa/FM/blob/e7afedcfdf9ba50eac8a9bdda6ce70a4d1ef709d/fsw/src/fm_app.h#L66-L79

Expected behavior Consolidate duplicated struct members to only exist (and be updated/accessed) in the housekeeping struct.

This more parsimonious approach is taken by several of the apps (CF, CS, MM, SC) as well as EVS and SB in the cFE.

Reporter Info Avi Weiss @thnkslprpt