[x] I signed and emailed the appropriate Contributor License Agreement to GSFC-SoftwareRelease@mail.nasa.gov and copied cfs-program@lists.nasa.gov.
Describe the contribution
Fixes #86
Removes boolean logic tracking file status which results in reduction of cyclomatic complexity to 9 from 17 by bundling logic in one single nested if/else according to file status.
Testing performed
lcov
build
cert_testbed cFE_EVS_ConcatFilesCmd.json functional test successful
Expected behavior changes
No impact to behavior
System(s) tested on
OS: Ubuntu 22.04
Additional context
Could be argued that the concat function is more readable as-is, but this way, the NASA recommendation of 15 max cyclomatic complexity per function is satisfied.
Third party code
N/A
Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, Vantage Systems
Checklist (Please check before submitting)
Describe the contribution
Testing performed
Expected behavior changes No impact to behavior
System(s) tested on
Additional context Could be argued that the concat function is more readable as-is, but this way, the NASA recommendation of 15 max cyclomatic complexity per function is satisfied.
Third party code N/A
Contributor Info - All information REQUIRED for consideration of pull request Justin Figueroa, Vantage Systems