nasa / FM

The Core Flight System (cFS) File Manager (FM) application.
Apache License 2.0
42 stars 24 forks source link

Convert command success events to `INFORMATION` type #114

Closed thnkslprpt closed 8 months ago

thnkslprpt commented 8 months ago

Checklist

Describe the bug Similar to DS issue 107 FM is out-of-family with most of cFS in declaring successful command EIDs as DEBUG type, and also not in line with the cFE Developer's Guide s7.2. See additional reasoning here which makes a lot of sense.

Code snips https://github.com/nasa/FM/blob/4c8c38385297d9c46e7d28a7bb727f097a742fc6/fsw/inc/fm_events.h#L304-L313 https://github.com/nasa/FM/blob/4c8c38385297d9c46e7d28a7bb727f097a742fc6/fsw/inc/fm_events.h#L358-L367 https://github.com/nasa/FM/blob/4c8c38385297d9c46e7d28a7bb727f097a742fc6/fsw/inc/fm_events.h#L412-L421 etc... (~20 cases total)

Expected behavior Successful/nominal command events should be defined as INFO type.

Reporter Info Avi Weiss   @thnkslprpt