nasa / FM

The Core Flight System (cFS) File Manager (FM) application.
Apache License 2.0
43 stars 25 forks source link

Fix #118, Standardize command responses #122

Closed thnkslprpt closed 1 month ago

thnkslprpt commented 5 months ago

Checklist

Describe the contribution

As per the discussion in the issue, most of the first list were already fixed, and the 2nd list I have left alone to maintain consistency - of the 8 'partial success' events that increment the ChildCmdWarnCounter, all are INFORMATION type, except FM_GET_FILE_INFO_OPEN_ERR_EID which is of ERROR type (perhaps need a separate issue to align this).

Testing performed GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).

Expected behavior changes As above.

System(s) tested on Debian GNU/Linux 11 (bullseye) Current main branch of cFS bundle.

Contributor Info Avi Weiss   @thnkslprpt

dzbaker commented 1 month ago

@thnkslprpt Thank you for the contribution! Would you be able to resolve the merge conflicts?

thnkslprpt commented 1 month ago

@thnkslprpt Thank you for the contribution! Would you be able to resolve the merge conflicts?

@dzbaker updated.