nasa / FM

The Core Flight System (cFS) File Manager (FM) application.
Apache License 2.0
43 stars 25 forks source link

Remove random numbers from unit tests #37

Closed astrogeco closed 2 years ago

astrogeco commented 2 years ago

Checklist (Please check before submitting)

Is your feature request related to a problem? Please describe. Several unit tests use the UT_UtilsAny* function to introduce randomness to tests that do not need it (and might actually be hurt by it).

See for example: https://github.com/nasa/FM/blob/51707f20350e4ea909842acb3597fff8da3ab18e/unit-test/fm_app_tests.c#L457-L464

And following searches https://github.com/nasa/FM/search?q=UT_Utils_Any_uint8&type=code https://github.com/nasa/FM/search?q=UT_Utils_Any_uint32&type=code https://github.com/nasa/FM/search?q=UT_Utils_Any_uint32_GreaterThan%280%29%3B&type=code https://github.com/nasa/FM/search?q=UT_Utils_Any_uint8_BetweenInclusive%3B&type=code https://github.com/nasa/FM/search?q=UT_Utils_Any_uint8_LessThan%3B&type=code

Describe the solution you'd like Remove use of these macros where unnecessary

Describe alternatives you've considered None

Additional context None

Requester Info Gerardo E. Cruz-Ortiz | NASA