nasa / FM

The Core Flight System (cFS) File Manager (FM) application.
Apache License 2.0
42 stars 24 forks source link

Unreachable code in fm_child.c, EntryLength never larger than sizeof(DirListData.EntryName) #44

Closed skliper closed 2 years ago

skliper commented 2 years ago

Checklist (Please check before submitting)

Is your feature request related to a problem? Please describe. Since both DirListData.EntryName and TempName are both OS_MAX_PATH_LENGTH, and and the os_dirent_t FileName is limited by OS_MAX_FILE_NAME, the first condition below can never be false: https://github.com/nasa/FM/blob/9210c2d314d3506fb50560d9bc6513c2b7fb4983/fsw/src/fm_child.c#L1496

Describe the solution you'd like Remove, the second condition is sufficient (add comment)

Describe alternatives you've considered None

Additional context None

Requester Info Jacob Hageman - NASA/GSFC