nasa / FM

The Core Flight System (cFS) File Manager (FM) application.
Apache License 2.0
42 stars 24 forks source link

Inconsistent Event ID naming #59

Closed thnkslprpt closed 2 months ago

thnkslprpt commented 1 year ago

Checklist

Describe the bug Copy of https://github.com/nasa/cFE/issues/2175 After finding that there were 9 different Event IDs to indicate the same thing (Invalid Message ID) in https://github.com/nasa/CF/issues/262, I scrubbed the other common commands (e.g. Task Initialisation [INIT], NOOP, Reset Counters etc.) and found the same issue there - almost every component/app had their own variation of the Event ID name for the exact same event.

Expected behavior Apply consistent Event ID names to the events which are common to all/most components and apps.

Code snips Invalid Message ID: CFE_EVS_ERR_MSGID_EID CFE_SB_BAD_MSGID_EID CFE_TIME_ID_ERR_EID CS_MID_ERR_EID TO_LAB_MSGID_ERR_EID SAMPLE_APP_INVALID_MSGID_ERR_EID BP_INVALID_MID_ERR_EID SCH_MD_ERR_EID CI_LAB_COMMAND_ERR_EID

Initialization: CFE_TIME_INIT_EID CFE_TBL_INIT_INF_EID CFE_EVS_STARTUP_EID CF_EID_INF_INIT BP_INIT_APP_INFO_EID SCH_INITSTATS_INF_EID CI_LAB_STARTUP_INF_EID

NOOP: CFE_TIME_NOOP_EID CFE_TBL_NOOP_INF_EID CFE_SB_CMD0_RCVD_EID CF_EID_INF_CMD_NOOP FM_NOOP_CMD_EID CI_LAB_COMMANDNOP_INF_EID

Reset Counters: CFE_TIME_RESET_EID CFE_TBL_RESET_INF_EID CFE_EVS_RSTCNT_EID CFE_SB_CMD1_RCVD_EID CF_EID_INF_CMD_RESET SC_RESET_DEB_EID HS_RESET_DBG_EID FM_RESET_CMD_EID HK_RESET_CNTRS_CMD_EID MD_RESET_CNTRS_DBG_EID CI_LAB_COMMANDRST_INF_EID

etc.

Reporter Info Avi Weiss @thnkslprpt