[x] I reviewed the README file to see if the feature is in the major future work.
[x] I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.
Is your feature request related to a problem? Please describe.
The FM_GlobalData object is only used within the FM app for private data storage. It should not be visible externally. However, it is currently defined here in the public fm_msg.h file:
Describe the solution you'd like
This should be defined in one of the internal header files, not in a public interface file.
Additional context
Public API should generally only be constants / #define's, and typedefs. API calls only for libraries - apps do not have public API calls. Extern data structs / globals should not be exposed in either apps or libs for a variety of reasons.
Requester Info
Joseph Hickey, Vantage Systems, Inc.
Checklist (Please check before submitting)
Is your feature request related to a problem? Please describe. The
FM_GlobalDataobject is only used within the FM app for private data storage. It should not be visible externally. However, it is currently defined here in the publicfm_msg.hfile:https://github.com/nasa/FM/blob/c8569975ba4d0a4ab656565b22511812385ad0bb/fsw/inc/fm_msg.h#L542-L594
Describe the solution you'd like This should be defined in one of the internal header files, not in a public interface file.
Additional context Public API should generally only be constants /
#define's, and typedefs. API calls only for libraries - apps do not have public API calls. Extern data structs / globals should not be exposed in either apps or libs for a variety of reasons.Requester Info Joseph Hickey, Vantage Systems, Inc.