nasa / FM

The Core Flight System (cFS) File Manager (FM) application.
Apache License 2.0
42 stars 24 forks source link

Fix #92, Use size_t for 'size' variables #93

Closed thnkslprpt closed 1 year ago

thnkslprpt commented 1 year ago

Checklist

Describe the contribution Fixes #92 Easy-to-find size variables converted to size_t type.

All except the local variables in FM_ChildDirListPktCmd() and FM_ChildDirListFileLoop() were already of type uint32, so no real risk of signedness issues popping up.

Note: I did not scrub the entire app - if someone can suggest some additional variables to convert over to size_t I can add them to this PR.

A few typos and spacing issues cleared up in the same files.

Testing performed GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes Variables representing size should use size_t where possible - more expressive and more compliant with the various (relevant) coding guidelines.

Contributor Info Avi Weiss @thnkslprpt

dzbaker commented 1 year ago

@thnkslprpt CCB 30 March 2023: Approved pending conflict resolution.

thnkslprpt commented 1 year ago

@thnkslprpt CCB 30 March 2023: Approved pending conflict resolution.

All done @dzbaker. Cheers