Remove unneeded params in model classes, renamed model to systemModel

nasa / GSAP

Generic Software Architecture for Prognostics (GSAP)

Other

20 stars 6 forks source link

Remove unneeded params in model classes, renamed model to systemModel #92

Closed teubert closed 6 years ago

jason-watkins commented 6 years ago

Why was auto-registration of battery removed from the SystemModel factory?

teubert commented 6 years ago

@jason-watkins I added auto-registration on the first commit. Prior to that the code was there, but it was commented out. The change was failing the linux build. I found that it was going to take some more time to diagnose, so I removed the added auto registration (since it wasn't the purpose of these changes) and left it for future work.

jason-watkins commented 6 years ago

I'm not sure why it was commented out... Anyway, the Factory class changed the way it does registrations in a way that made the commented out code break. It should be fixed in the commit I just pushed.