search

nasa / GSAP

Generic Software Architecture for Prognostics (GSAP)
Other
22 stars 6 forks source link

Fixed typo #97

Closed kdarafsh closed 5 years ago

kdarafsh commented 5 years ago

The model would become unstable due to incorrectly computed positive surface mole fraction.

jason-watkins commented 5 years ago

Looks like this change causes the following tests to fail: "UKF Step for Battery" and "Battery State Eqn". Given the nature of the change, I'm inclined to think the proper course of action is to update the tests to accept the new values.

teubert commented 5 years ago

Agreed! @kdarafsh has also confirmed that with these changes the output of the model matches that of the battery model in the Matlab PrognosticsModelLibrary