nasa / LC

The Core Flight System (cFS) Limit Checker (LC) application.
Apache License 2.0
30 stars 21 forks source link

Fix #53, Remove stray refs to old event type constants #54

Closed thnkslprpt closed 1 year ago

thnkslprpt commented 1 year ago

Checklist

Describe the contribution

Alternative to updating these is to delete these (commented-out) lines.

Either way, the references to the old event types should not remain, as if any of these tests are un-commented-out it will cause a build failure.

Testing performed GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes No impact on behavior.

Contributor Info Avi Weiss @thnkslprpt

thnkslprpt commented 1 year ago

Hmm, this appears to be all in "commented-out" code blocks. My recommendation is that we should just remove them entirely. In general we discourage having commented-out code in the repo (history is what git is for).

Great idea! Who doesn't love deleting superfluous code.