nasa / LC

The Core Flight System (cFS) Limit Checker (LC) application.
Apache License 2.0
30 stars 21 forks source link

Remove use of compiler extension in LC table file definitions #69

Closed jphickey closed 1 year ago

jphickey commented 1 year ago

Checklist (Please check before submitting)

Is your feature request related to a problem? Please describe. The __attribute__((__used__)) is a GNU compiler extension flag and such constructs should be avoided in portable code.

Describe the solution you'd like Remove

Additional context This flag is only in there to avoid a warning due to the use of static - but this object should not be static to begin with, then everything works without the use of special flags.

Requester Info Joseph Hickey, Vantage Systems, Inc.

jphickey commented 1 year ago

There is a additional inconsistency in the table defs in that the tables have the word "Default" baked into their name -- LC_DefaultADT and LC_DefaultWDT. In reality the tables are called LC_ADT and LC_WDT, respectively. These just happen to be the default values for those tables (that's OK), but the runtime name of the table should not change based on whether it is the default value or not.