Refactor multiple return statements in `LC_CreateTaskCDS()` - Githubissues

nasa / LC

The Core Flight System (cFS) Limit Checker (LC) application.

Apache License 2.0

30 stars 21 forks source link

Refactor multiple return statements in `LC_CreateTaskCDS()` #92

Open thnkslprpt opened 1 year ago

thnkslprpt commented 1 year ago

Checklist

[x] I reviewed the Contributing Guide.
[x] I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug

Issue https://github.com/nasa/LC/issues/36 was partially addressed with PR:
- https://github.com/nasa/LC/pull/68 Opening this issue to address the 2nd half - refactoring the multiple returns out of LC_CreateTaskCDS() and simplify its control flow.

Code snips https://github.com/nasa/LC/blob/45f8e87dc985d04424cad67f0b6e556efa4ce114/fsw/src/lc_app.c#L734-L853

Expected behavior Single entry/exit point.

Reporter Info Avi Weiss @thnkslprpt