Broken RTS message, out of sync with SC

[skliper]

Checklist (Please check before submitting)

• [x] I reviewed the Contributing Guide.
• [x] I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug Critically broken. Local defn of start RTS command is out of sync with SC: https://github.com/nasa/LC/blob/ca4767089966c6ba5b308fa42272763a6881c192/config/default_lc_msgstruct.h#L231-L248

https://github.com/nasa/SC/blob/ab3a9a03aee8fb9826077c0492f4b7698132c057/config/default_sc_msgdefs.h#L251-L258

Really the concept of local defines for SC elements doesn't seem like a good idea. LC depends on SC, the message structure, CC, and MID should come from SC.

To Reproduce Trigger an RTS from LC. Event received: 66/1/SC 2: Invalid msg length: ID = 0x000018A9, CC = 4, Len = 10, Expected = 12

Expected behavior Command should work

Code snips See above

System observed on: On an Ubuntu 22 docker, issue is in main branches.

Additional context Might be missing a functional test or need an update if this is currently passing.

Reporter Info Jacob Hageman - NASA/GSFC

[skliper]

Note, padding has existed in SC since 3.1.0-rc1 (May 2022): https://github.com/nasa/SC/blob/ae2d615e7431d430950fd25ccc7e85587c03ad95/fsw/src/sc_msg.h#L158-L164

It was not in 2.5.0: https://github.com/nasa/SC/blob/83490def6f8882fbdc2df6592bc319fd96ac2a8b/fsw/src/sc_msg.h#L184-L192