[Data] Dictionary import sometimes fails

[VWoeltjen]

In Data plugin, Import > Dictionary does not behave as expected:

• If the Data Taxonomy node has ever been expanded, the node remains empty after the Import > Dictionary action
• If user imports successfully, then restarts MCT, Data Taxonomy appears empty
• If user selects imported data components and chooses Place Objects in New Collection, the resulting collection is empty

Desired behavior is that Data Taxonomy (re)populates as necessary when dictionary is imported, and that the resulting objects may be placed in collections to support display-building.

[VWoeltjen]

I've taken a quick look at this - at least part of the problem seems to be that persistence is failing due to encountering duplicates (that is, an exception is being hit in the persist(components) call) in component ids, either from prior imports or within the current import.

Commit with some changes to work around this is at: https://github.com/VWoeltjen/MCT-Plugins/commit/15cb6552e444c22a4b450728cd5d64ba1ae5eead

The above appears to fix the second and third bullets from the original issue; not clear to me why Data Taxonomy still appears empty in the tree.

[JieD]

I did very minor changes. But I couldn’t reproduce the problem stated in the first bullet.

[VWoeltjen]

These are the steps I recall reproducing the problem from the first bullet:

• Start MCT with data taxonomy plugin and a no existing database
• Click on twistie next to Data Taxonomy
  • As expected, twistie disappears and Data Taxonomy remains empty
• Right click Data Taxonomy, Import > Dictionary, pick a csv file, hit Save
  • Unexpectedly, Data Taxonomy still appears empty

It may be the case that the CSV file used must contain duplicates for this issue to occur.

[VWoeltjen]

Note that first bullet seems to need a large data dictionary (e.g. 20000+ lines) to be reproducible