nasa / MCT-Plugins

35 stars 29 forks source link

[Scenario] enable drawing cost graph for older TimelineComponent #172

Closed JieD closed 10 years ago

JieD commented 10 years ago

New TimelineComponent introduces BatteryModel, which is used when drawing cost graphs. For backward compatibility, older TimelineComponent’s cost graph only shows Power and Comm. Note that the property editor for new TimelineComponent has editable fields associated with BatteryModel. These fields are disabled for older TimelineComponent.

Wrote or re-wrote unit tests (Y/N): N Ran entire suite of unit tests successfully (Y/N): N Verified bug fix with the described replication steps or verified the implementation meets the requirement cited (Y/N): N Code coverage requirements satisfied (new code=80%, changed code=at least as high as existing) (Y/N): N Code review date and attendees: Code review by pull request Describe potential impact on other areas of the code: Scenario Describe any test prerequisites for this fix (e.g., restart the database): NA For bugs marked "Regression - Yes", describe the cause of the regression: Did you modify any pom.xml file? If yes, did you thoroughly document your changes and reasons? N

VWoeltjen commented 10 years ago

Looks good, thanks