nasa / MD

The Core Flight System (cFS) Memory Dwell (MD) application.
Apache License 2.0
25 stars 18 forks source link

MD is unable to dwell on application-private symbols #14

Closed jhnphm closed 2 years ago

jhnphm commented 2 years ago

Checklist (Please check before submitting)

Is your feature request related to a problem? Please describe. MD is unable to get application symbols, due to changes in cFE to make application symbols private: https://github.com/nasa/cFE/issues/952

Describe the solution you'd like Using OS_ModuleSymbolLookup should be an option to peek/telemeter app-private symbols

Describe alternatives you've considered Leave as-is; implementation of OS_ModuleSymbolLookup is the same as OS_SymbolLookup on vxWorks anyways, so it would appear this would only affect Linux.

Additional context https://github.com/nasa/MD/blob/408ff72c9ffa5001a11952df93e99d1bdccd576c/fsw/src/md_utils.c#L216

Requester Info John Pham, Northrop Grumman

skliper commented 2 years ago

This should be already fixed on Linux, see https://github.com/nasa/osal/pull/1206. The generic lookup will search both global and module symbol tables.

jhnphm commented 2 years ago

Ah, I missed that update. I'll close the ticket.