nasa / MD

The Core Flight System (cFS) Memory Dwell (MD) application.
Apache License 2.0
25 stars 18 forks source link

Combine consecutive, mutually-exclusive status checks #52

Closed thnkslprpt closed 1 year ago

thnkslprpt commented 1 year ago

Checklist

Describe the bug md_app.c contains a couple of consecutive, mutually exclusive status checks.

Code snips https://github.com/nasa/MD/blob/116d2986500101551beb32bcd3fa30de4cfd39b9/fsw/src/md_app.c#L188-L197 https://github.com/nasa/MD/blob/116d2986500101551beb32bcd3fa30de4cfd39b9/fsw/src/md_app.c#L274-L283

Expected behavior Combine into an if/else - no need to do 2 evaluations.

Reporter Info Avi Weiss @thnkslprpt