nasa / MD

The Core Flight System (cFS) Memory Dwell (MD) application.
Apache License 2.0
25 stars 18 forks source link

Fix #59, remove unneeded stack object #60

Closed jphickey closed 11 months ago

jphickey commented 11 months ago

Checklist (Please check before submitting)

Describe the contribution Remove the Initial dwell table object from MD_InitTableServices. This object was not actually used, and consumed several kB of stack space unnecessarily, depending on the size of the table.

Fixes #59

Testing performed Run MD in sample config

Expected behavior changes Peak stack use decreases by about 2kB (which is sizeof(MD_DwellTableLoad_t))

System(s) tested on Debian

Additional context This extra object made it more likely for MD to overrun its stack during startup vs other similar CFS apps. This was particularly the case where small stack sizes were used (e.g. 8kB).

Contributor Info - All information REQUIRED for consideration of pull request Joseph Hickey, Vantage Systems, Inc.