search

nasa / PSP

The Core Flight System (cFS) Platform Support Package (PSP)
Apache License 2.0
66 stars 56 forks source link

Formatting Issues with ICBundle Workflow #399

Closed dzbaker closed 10 months ago

dzbaker commented 11 months ago

Describe the bug Similar to nasa/cFE#2419. There are some small formatting issues that should be corrected in the changelog/version.h updates made by the ICBundle workflow:

  1. An additional "#" is placed in front of "#define CFE_PSP_IMPL_BUILD_NUMBER ..." in fsw/mcp750-vxworks/inc/psp_version.h
  2. An additional "#" is placed in front of "#define CFE_PSP_IMPL_BUILD_NUMBER ..." in fsw/pc-linux/inc/psp_version.h
  3. An additional "#" is placed in front of "#define CFE_PSP_IMPL_BUILD_NUMBER ..." in fsw/pc-rtems/inc/psp_version.h

To Reproduce Steps to reproduce the behavior:

  1. Push a code change to a user-owned feature branch
  2. Submit a pull request for that code change
  3. Go to the "Actions" tab in GitHub and run the "Integration Candidate Bundle Generation" workflow with the PR number as the input argument for the field labeled "The pull request numbers to include (Comma separated):"
  4. Wait for the workflow to complete
  5. Inspect the newly updated/generated "integration-candidate branch"
  6. Observe the changes made to the fsw/mcp750-vxworks/inc/psp_version.h, fsw/pc-linux/inc/psp_version.h, and fsw/pc-rtems/inc/psp_version.h files by the workflow

Expected behavior

  1. No additional "#" is placed in front of "#define OS_BUILD_NUMBER ..." in fsw/mcp750-vxworks/inc/psp_version.h
  2. No additional "#" is placed in front of "#define OS_BUILD_NUMBER ..." in fsw/pc-linux/inc/psp_version.h
  3. No additional "#" is placed in front of "#define OS_BUILD_NUMBER ..." in fsw/pc-rtems/inc/psp_version.h

System observed on: GitHub

Reporter Info Dylan Z. Baker/NASA GSFC