nasa / SC

The Core Flight System (cFS) Stored Commands (SC) application.
Apache License 2.0
38 stars 20 forks source link

All CMD/TLM messages should put content in a "Payload" sub-structure #99

Closed havencarlson closed 1 year ago

havencarlson commented 1 year ago

Checklist (Please check before submitting)

Is your feature request related to a problem? Please describe. To match the patterns used in CFE and other modules, all CMD/TLM message definitions should put the content (non-header) parts into a separate struct called "Payload".

Describe the solution you'd like Separate message content into a sub structure called "Payload".

Additional context This is benefit to tooling that can use the presence of this field to identify where the actual content starts (e.g. something like offsetof(MsgType, Payload) would work and be correct, as opposed to checking sizeof(CFE_MSG_CommandHeader_t) which may not actually reflect where the content starts due to possible compiler-added padding between them).

Requester Info Haven Carlson - NASA