search

nasa / Transform-to-Open-Science

Transformation to Open Science
Other
715 stars 145 forks source link

OS101 Module 2, Lesson 1 - typo in image #639

Open NPalopoli opened 6 months ago

NPalopoli commented 6 months ago

In this image in Module 2, Lesson 1, there's a missing 'e' at the end of 'BSD 3-Clause' in the top-right 'TL-DR' box.

(Note: edited with correct link)

SLLDeC commented 6 months ago

@NPalopoli The image doesn't show. The link throws a 'Not Found' message.

NPalopoli commented 6 months ago

Thanks for noticing! I've corrected the link.

bressler95tops commented 6 months ago

Thank you for pointing that out @NPalopoli. We will be reviewing curriculum suggestions hopefully within the next couple weeks as we make some adjustments to the first release and citation information so definitely let us know if you find anything else and stay tuned.

katblanchette commented 2 months ago

@bressler95tops - Please correct. Thanks!

bressler95tops commented 2 months ago

@katblanchette I just corrected the link for Nicolas's issue submission. This was prior to us moving everything to its own branch for the citable version of OS101. This one also was fairly easy to open up in Illustrator, do an image trace and add the letter. I can upload the source to the internal graphics folder you shared so we all have it for easy edits since this didn't seem to be included with the existing sources. I will replace it in the content and update here, I just figured I would give some background to the fix first. M2L1BSDClause-01

katblanchette commented 1 month ago

@bressler95tops - Thank you for the information and thank you for adding the "e" to Claus in the image. Please move forward with replacing image with the new image in GitHub, and the OS101 Team will also notify the Developers and update the ILT slides. Will you upload the corrected image into the Module 2 Graphics folder? We will notify you when these files are updated.

bressler95tops commented 1 month ago

Thanks @katblanchette. I have gone ahead and made the replacement. As usual, the PR has been addressed in PR #772. You can see exact details in the files changed tab.

bressler95tops commented 1 month ago

I will also add those images to the locations you mentioned.