Update check_code.py - Githubissues

nasa / TrickHLA

TrickHLA: An IEEE 1516 High Level Architecture (HLA) Simulation Interoperability Standard Implementation for Trick Base Simulations

Other

38 stars 15 forks source link

Update check_code.py #89

Closed jiajlin closed 3 years ago

jiajlin commented 3 years ago

fixed the following bug:

if CPPCHECK_HOME environment variable is set and points to a valid directory, the cppcheck_command variable would only get set if verbose mode is true.

dandexter commented 3 years ago

Thank you for finding this bug caused by indenting. To prevent this bug from happening again could you please move the one line comment and one line of code building the command to be before the if statement checking for verbose. This should make the code easier to read and less prone for this to happen again.

jiajlin commented 3 years ago

check_code.py is updated with the suggested change.

dandexter commented 3 years ago

Thank you for your contribution.