nasa / apod-api

Astronomy Picture of the Day API service
Apache License 2.0
833 stars 162 forks source link

API returns 404 "No data available" when asking for latest date #48

Open jtbandes opened 4 years ago

jtbandes commented 4 years ago

When I make an API call to https://api.nasa.gov/planetary/apod?api_key=DEMO_KEY right now (Thu, 01 Oct 2020 01:30:49 GMT) I get a 404:

{
  "code": 404,
  "msg": "No data available for date: 2020-10-01",
  "service_version": "v1"
}

It’s currently Sep 30 in my time zone, not Oct 1. I understand if the server wants to give me Oct 1’s image after midnight UTC, but if so it shouldn’t give me a 404.

I suspect that's because the "current date" default sometimes changes before the image is actually made available (due to time zone differences, maybe?):

https://github.com/nasa/apod-api/blob/a434768b5a3d5f4ecd40adeadb1f2db3daf2ec16/application.py#L127-L129

However it looks like there is already some code to handle this. So I guess that's not working properly:

https://github.com/nasa/apod-api/blob/a434768b5a3d5f4ecd40adeadb1f2db3daf2ec16/apod/utility.py#L263-L271

gumbarros commented 4 years ago

I'm having this issue right now

jtbandes commented 4 years ago

Yeah, it happens every evening when the date changes. (Edit: at least I've noticed it for a couple days in the past week.)

ibll commented 4 years ago

I’ve never had it happen like this.

gumbarros commented 4 years ago

Client-side solution:

https://github.com/gumbarros/kepler/blob/master/lib/src/services/api/api.dart#L38

jtbandes commented 4 years ago

My workaround (above) is to request a date range starting from yesterday and using the last item in the returned list. I don't include the end_date because an end_date of tomorrow returns a 400 error 😕

nwunderly commented 4 years ago

I had been wondering about this myself. Found it when my code started crashing at exactly 8pm EDT. I assumed it was intentional but couldn't imagine why the date parameter, when left out, defaulted to "today UTC" and not "most recent valid date". Would certainly make things easier for users.

kmpoppe commented 3 years ago

I'm using the APOD API in Cypht (https://github.com/jasonmunro/cypht) and found it morning, that there was no new picture at 04:30am CET but at 06:30am - after a quick glance at nasa.gov it seems that they format all their times in EST/EDT. I have now changed the module to just calculate what day it is in EST - and just not request the "current" day my server has. A quick mail to Robert Nemiroff (one of the creators of APOD) confirmed this idea. So my guess is, that this is by design and won't be fixed - even though I think that providing the "next" day would do no harm. Just as a reminder, the archive accessible at https://apod.nasa.gov/apod/archivepix.html also doesn't list the next day and guessing the URL of the next day results in a 404 - so the whole APOD would need to be prepared for always providing the next day information.

elementh commented 3 years ago

@kmpoppe I'm doing the same in a wrapper I'm preparing . Seems to be the only plausible solution :/

kmpoppe commented 3 years ago

@elementh I've linked my PR for the Cypht project. Maybe you can find some inspiration there.

elementh commented 3 years ago

@kmpoppe I will, thank you very much!

nwunderly commented 3 years ago

51 should have fixed this issue, no?

elementh commented 3 years ago

but that means having specific code to handle a whatever means "today" for the user and erase that from the request.

51 It's helpful but can still can't handle every case.