nasa / bingo

Apache License 2.0
47 stars 28 forks source link

Explicit/Implicit TrainingData read access to data #27

Closed tylertownsend closed 3 years ago

tylertownsend commented 4 years ago

In implicit and explicit training data, the parameters of x and y (or dx_dt for implicit) are passed to the constructor to create a new instance. However, the constructor verifies that the data is shaped correctly. Because the member variables are exposed for both read and write access, this reshaping can be skipped and the data structure can be broken. Add read only properties to the values.

gbomarito commented 3 years ago

finally got around to implementing this, thanks