search

nasa / bplib

Apache License 2.0
27 stars 13 forks source link

Fix #181, add bplib_os submodule to property propagation list #188

Closed jphickey closed 1 year ago

jphickey commented 1 year ago

There are two loops in the top level CMakeLists.txt file that convey certain properties of the main library (bplib) to properties of the submodules so they will be compatible. The newly-added bplib_os submodule was inadvertly missing from this set, resulting in an unlinkable binary in some configurations.

Fixes #181

jphickey commented 1 year ago

Discussed at 2022-10-26 CCB, conceptually approved pending review

jphickey commented 1 year ago

Received confirmation from PDL that this can now be approved, label switched.