Cppcheck errors reported in file_offload.c

[jphickey]

Describe the bug Initial manual run of cppcheck reports the following concerns:

Checking store/file_offload.c ...
store/file_offload.c:512:101: style: inconclusive: Function 'bplib_file_offload_restore' argument 3 names different: declaration 'pblk' definition 'pblk_out'. [funcArgNamesDifferent]
static int bplib_file_offload_restore(bplib_mpool_block_t *svc, bp_sid_t sid, bplib_mpool_block_t **pblk_out)
                                                                                                    ^
store/file_offload.c:48:101: note: Function 'bplib_file_offload_restore' argument 3 names different: declaration 'pblk' definition 'pblk_out'.
static int bplib_file_offload_restore(bplib_mpool_block_t *svc, bp_sid_t sid, bplib_mpool_block_t **pblk);
                                                                                                    ^
store/file_offload.c:512:101: note: Function 'bplib_file_offload_restore' argument 3 names different: declaration 'pblk' definition 'pblk_out'.
static int bplib_file_offload_restore(bplib_mpool_block_t *svc, bp_sid_t sid, bplib_mpool_block_t **pblk_out)
                                                                                                    ^
store/file_offload.c:372:9: error: Uninitialized variable: eblk [uninitvar]
    if (eblk != NULL)
        ^
store/file_offload.c:372:9: error: Uninitialized variable: eblk [uninitvar]
    if (eblk != NULL)
        ^
store/file_offload.c:342:21: note: Assuming condition is false
    if (read_status == BP_SUCCESS)
                    ^
store/file_offload.c:372:9: note: Uninitialized variable: eblk
    if (eblk != NULL)
        ^
store/file_offload.c:190:20: style: Variable 'result' is assigned a value that is never used. [unreadVariable]
            result = mkdir(name_buf, 0755);
                   ^
store/file_offload.c:196:20: style: Variable 'result' is assigned a value that is never used. [unreadVariable]
            result = mkdir(name_buf, 0755);
                   ^

To Reproduce Execute cppcheck against source code

Expected behavior Should execute cleanly with no errors reported

System observed on: Ubuntu 22.04

Reporter Info Joseph Hickey, Vantage Systems, Inc.