nasa / bplib

Apache License 2.0
27 stars 13 forks source link

Cppcheck errors reported in lib/src/v7_routing.c #192

Closed jphickey closed 1 year ago

jphickey commented 1 year ago

Describe the bug Initial manual run of cppcheck reported the following concerns:

Checking lib/src/v7_routing.c ...
lib/src/v7_routing.c:337:18: style: Condition 'base_ptr==NULL' is always false [knownConditionTrueFalse]
    if (base_ptr == NULL)
                 ^
lib/src/v7_routing.c:53:25: style: struct member 'bplib_routetbl::max_routes' is never used. [unusedStructMember]
    uint32_t            max_routes;
                        ^
lib/src/v7_routing.c:54:25: style: struct member 'bplib_routetbl::registered_routes' is never used. [unusedStructMember]
    uint32_t            registered_routes;
                        ^
lib/src/v7_routing.c:56:25: style: struct member 'bplib_routetbl::maint_request_flag' is never used. [unusedStructMember]
    volatile bool       maint_request_flag;
                        ^
lib/src/v7_routing.c:57:25: style: struct member 'bplib_routetbl::maint_active_flag' is never used. [unusedStructMember]
    volatile bool       maint_active_flag;
                        ^
lib/src/v7_routing.c:58:25: style: struct member 'bplib_routetbl::poll_count' is never used. [unusedStructMember]
    uint8_t             poll_count;
                        ^
lib/src/v7_routing.c:59:25: style: struct member 'bplib_routetbl::last_intf_poll' is never used. [unusedStructMember]
    uint64_t            last_intf_poll;
                        ^
lib/src/v7_routing.c:60:25: style: struct member 'bplib_routetbl::routing_success_count' is never used. [unusedStructMember]
    uintmax_t           routing_success_count;
                        ^
lib/src/v7_routing.c:61:25: style: struct member 'bplib_routetbl::routing_error_count' is never used. [unusedStructMember]
    uintmax_t           routing_error_count;
                        ^
lib/src/v7_routing.c:62:25: style: struct member 'bplib_routetbl::pool' is never used. [unusedStructMember]
    bplib_mpool_t      *pool;
                        ^
lib/src/v7_routing.c:64:25: style: struct member 'bplib_routetbl::route_tbl' is never used. [unusedStructMember]
    bplib_routeentry_t *route_tbl;
                        ^
lib/src/v7_routing.c:230:28: style: struct member 'routeentry_align::byte' is never used. [unusedStructMember]
        uint8_t            byte;
                           ^

To Reproduce Execute cppcheck against source code

Expected behavior Should execute cleanly with no errors reported

System observed on: Ubuntu 22.04

Reporter Info Joseph Hickey, Vantage Systems, Inc.

jphickey commented 1 year ago

Note on this one, these struct members definitely are used, there is something odd about this report in that the tool isn't seeing it for some reason. May need to tweak the cppcheck configuration somehow.