search

nasa / bplib

Apache License 2.0
30 stars 13 forks source link

Fix #176, implement mpool test cases #219

Closed jphickey closed 1 year ago

jphickey commented 1 year ago

Describe the contribution Implement test cases to cover all mpool implementation. There are a few branches which are justifiably unreachable.

Fix #176

Testing performed Build and run tests, confirm full coverage (as close to 100% that is achievable)

Expected behavior changes Coverage test is implemented

System(s) tested on Ubuntu

Additional context Remaining uncovered lines/branches are genuinely not reachable - comments in FSW even say "this should never happen" so that is expected. However removing the conditional could reduce robustness of the code, so my inclination is to keep them as-is for now, just leave it as uncovered.

Contributor Info - All information REQUIRED for consideration of pull request Joseph Hickey, Vantage Systems, Inc.

jphickey commented 1 year ago

Updated to fix some assert() failures noted by @glan6388. Remaining issue is related to get_dtntime stub, and fixed separately in #218.

jphickey commented 1 year ago

Reviewed and approved at 2022-11-30 CCB, but because this is dependent on #217, need to wait until that one is ready to merge before merging this.