search

nasa / bplib

Apache License 2.0
27 stars 13 forks source link

fix #182, add workflow coverage test #222

Closed glan6388 closed 1 year ago

glan6388 commented 1 year ago

Describe the contribution Added Workflow Coverage Test files for bplib

Testing performed CentOS 7

Expected behavior changes Auto Run coverage test in github

System(s) tested on CentOS 7

Contributor Info - All information REQUIRED for consideration of pull request George Lan MCSG Technologies

jphickey commented 1 year ago

I actually don't think we need to re-run coverage as a separate workflow, because coverage results are already being reported in the build/run workflow.

However, I would like to see minimum coverage enforcement (that is, the workflow will fail if a PR makes the number of uncovered lines/branches go up). This can catch cases where a developer makes a new feature/fix but forgets to update the test accordingly - happens frequently!

I believe OSAL and CFE both do this so there should be examples of how it can be checked.