search

nasa / bplib

Apache License 2.0
30 stars 13 forks source link

Fix #252, propagate error code after decode failure #255

Closed jphickey closed 1 year ago

jphickey commented 1 year ago

Describe the contribution The "bplib_generic_bundle_ingress()" function was not correctly propagating an error status from the underlying decode operation. It was logging the error but using the return value from the bplog macro, which will be BP_SUCCESS.

This also updates the coverage tests to use "INT32_EQ" rather than "UINT32_EQ", as the return value from these API calls is a signed integer.

Fixes #252

Testing performed Unit test cases updated to cover this case Pass in bundle using unsupported features

Expected behavior changes The bplib_cla_ingress() function will return BP_ERROR if the bundle being passed in does not decode successfully

System(s) tested on Debian

Contributor Info - All information REQUIRED for consideration of pull request Joseph Hickey, Vantage Systems, Inc.

jphickey commented 1 year ago

Reviewed and approved at 2023-09-27 CCB