search

nasa / bplib

Apache License 2.0
27 stars 13 forks source link

DTNN-330-Replace TinyCBOR APIs with QCBOR APIs-Draft #259

Open glan6388 opened 2 months ago

glan6388 commented 2 months ago

Describe the contribution DTNN-330, replace TinyCBOR APIs with QCBOR APIs

Testing performed Steps taken to test the contribution:

  1. Build and install QCBOR
  2. Built standalone POSIX version of bplib
  3. Run two bpcat servers with different node IDs and local IP. They will send messages through bundle protocol.

Expected behavior changes Replace the TinyCBOR APIs with QCBOR APIs for CBOR encoder and decoder. Behavior should be the same

System(s) tested on

Additional context Add any other context about the contribution here.

Contributor Info - All information REQUIRED for consideration of pull request George Lan george.lan@nasa.gov

gskenned commented 2 months ago

Does QCBOR require sudo to install?

sara-gb commented 2 months ago

Just a general question for the PR, but how were these changes tested? How do you think QCBOR compared to TinyCBOR?

keegan-moore commented 1 month ago

@glan6388 - could you pull in the latest readme updated, then update them to show how to install QCBOR?