The file storage service code assumes that the bp_sid_t type is 64 bits, yet on 32-bit platforms the bp_sid_t type being a void* is only 32 bits.
In practice, this has not manifested itself because the data_ids used by the file storage service have not exceeded 32-bit numbers.
It may be preferable to use a fixed width 64-bit integer for the sid so that storage services like files and flash devices which do not use bus memory addresses can map to it intuitively. Whatever fix is made, it must maintain that a zero sid is invalid.
jpswinski
commented
4 years ago
The file storage service code assumes that the bp_sid_t type is 64 bits, yet on 32-bit platforms the bp_sid_t type being a void* is only 32 bits.
In practice, this has not manifested itself because the data_ids used by the file storage service have not exceeded 32-bit numbers.
It may be preferable to use a fixed width 64-bit integer for the sid so that storage services like files and flash devices which do not use bus memory addresses can map to it intuitively. Whatever fix is made, it must maintain that a zero sid is invalid.