search

nasa / cFE

The Core Flight System (cFS) Core Flight Executive (cFE)
Apache License 2.0
408 stars 200 forks source link

Use a statically constructed table for SB filter initialization #1468

Open skliper opened 3 years ago

skliper commented 3 years ago

Is your feature request related to a problem? Please describe. No need to store filter settings in global or individually process: https://github.com/nasa/cFE/blob/c8b5e00bb722d8f59787ae8f82634feba5d39f60/modules/sb/fsw/src/cfe_sb_task.c#L144-L199

Describe the solution you'd like Statically construct the table and use it for initialization, can loop through it for size test.

Describe alternatives you've considered Not sure how consistent this pattern is, but another candidate for #994 and use for all the services (available for apps if they want it).

Additional context Code review

Requester Info Jacob Hageman - NASA/GSFC

skliper commented 3 years ago

See also #1919 which really suggests a refactor of this code. This pattern of self-filtering isn't all that friendly to ops, better to design events to not spam to begin with (and put counters in tlm).