wrong closing parenthesis in CFE_MSG_CMD_HDR_INIT macro

nasa / cFE

The Core Flight System (cFS) Core Flight Executive (cFE)

Apache License 2.0

413 stars 203 forks source link

wrong closing parenthesis in CFE_MSG_CMD_HDR_INIT macro #2317

Open mgbark23 opened 1 year ago

mgbark23 commented 1 year ago

The CFE_MSG_CMD_HDR_INIT macro's parentheses are not properly balanced.

The CFE_MSG_CMD_HDR_INIT macro contains a ')' instead of a '}' in line 70 as of Latest commit [f9112b4] on Jun 7, 2022 File: nasa/cFE/modules/msg/option_inc/default_cfe_msg_hdr_priext.h

Simple inspection shows the problem.

Opening and closing parentheses should be balanced.

line 70: .SystemId = {0, 0) \

Matthias Bark, Boeing

thnkslprpt commented 1 year ago

There is also an unbalanced (extra) round bracket/parenthesis:

Screenshot 2023-05-02 11 19 15