nasa / cFE

The Core Flight System (cFS) Core Flight Executive (cFE)
Apache License 2.0
402 stars 198 forks source link

Fix #2536, msg api test buffer overrun #2537

Closed jphickey closed 1 month ago

jphickey commented 3 months ago

Checklist (Please check before submitting)

Describe the contribution Corrects the buffer type used in the msg api tests, to be sized appropriately for either command or telemetry. When the secondary header accessor from the other type is used, it will not overrun the buffer.

Fixes #2536

Testing performed Run functional tests

Expected behavior changes No buffer overrun reports when using -fsanitize=address

System(s) tested on Debian

Contributor Info - All information REQUIRED for consideration of pull request Joseph Hickey, Vantage Systems, Inc.

jphickey commented 2 months ago

Should be ready now. This now has two separate buffers (cmd and tlm) and allows either operation (checksum, timestamp) to independently work or not work on either buffer.